abreis commented on pull request #9454: URL: https://github.com/apache/arrow/pull/9454#issuecomment-779802841
> I left two small suggestions. This looks really good :) > > Also, note that there is a potential optimization for all SIMD here where we create an un-initialized buffer and write to it directly from SIMD (instead of creating a zeroed buffer and writing to it) Thanks! I went to try and implement this, but it looks like it's already optimized as you suggest. `simd_` methods do: ```rust let mut result = MutableBuffer::new(buffer_size).with_bitset(buffer_size, false); ``` to prepare the return buffer, which uses `memory::allocate_aligned` internally, which does not initialize the newly-allocated memory region. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
