adamreeve commented on code in PR #41144:
URL: https://github.com/apache/arrow/pull/41144#discussion_r1560401286
##########
csharp/src/Apache.Arrow/Arrays/ArrayData.cs:
##########
@@ -28,12 +27,25 @@ public sealed class ArrayData : IDisposable
public readonly IArrowType DataType;
public readonly int Length;
- public readonly int NullCount;
+ private int _nullCount;
public readonly int Offset;
public readonly ArrowBuffer[] Buffers;
public readonly ArrayData[] Children;
public readonly ArrayData Dictionary; // Only used for dictionary type
+ public int NullCount
Review Comment:
Is this ABI breakage acceptable? I expect most users would access the null
count from the Array rather than ArrayData so it might not affect too many
users. But as an alternative I could add a new property and mark this one as
obsolete, or maybe just always compute the null count in the constructor rather
than doing it on demand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
