CurtHagenlocher commented on code in PR #41144:
URL: https://github.com/apache/arrow/pull/41144#discussion_r1561016354
##########
csharp/src/Apache.Arrow/Arrays/ArrayData.cs:
##########
@@ -111,7 +123,25 @@ public ArrayData Slice(int offset, int length)
length = Math.Min(Length - offset, length);
offset += Offset;
- return new ArrayData(DataType, length, RecalculateNullCount,
offset, Buffers, Children, Dictionary);
+ int nullCount;
+ if (NullCount == 0)
Review Comment:
This would force calculation of the null count on the original array. Is it
worth preserving laziness and saying "if we haven't calculated the original
null count then mark the sliced null count as requiring calculation"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
