ClifHouck commented on code in PR #40957:
URL: https://github.com/apache/arrow/pull/40957#discussion_r1562543926
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1206,7 +1206,7 @@ Status ConvertDictionaryToDense(const ::arrow::Array&
array, MemoryPool* pool,
}
static inline bool IsDictionaryEncoding(Encoding::type encoding) {
- return encoding == Encoding::PLAIN_DICTIONARY;
+ return encoding == Encoding::PLAIN_DICTIONARY || encoding ==
Encoding::RLE_DICTIONARY;
Review Comment:
Someone check me here. Is there some reason why this function wasn't
considering `RLE_DICTIONARY` before? Or was it just an omission?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
