mapleFU commented on code in PR #40957:
URL: https://github.com/apache/arrow/pull/40957#discussion_r1562703901
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1206,7 +1206,7 @@ Status ConvertDictionaryToDense(const ::arrow::Array&
array, MemoryPool* pool,
}
static inline bool IsDictionaryEncoding(Encoding::type encoding) {
- return encoding == Encoding::PLAIN_DICTIONARY;
+ return encoding == Encoding::PLAIN_DICTIONARY || encoding ==
Encoding::RLE_DICTIONARY;
Review Comment:
There're some points:
1.
https://github.com/apache/arrow/blob/main/cpp/src/parquet/encoding.cc#L444-L445
. `encoding` is not passed in Encoder
2. But shit, it's RLE in decoder 😅:
https://github.com/apache/arrow/blob/main/cpp/src/parquet/encoding.cc#L1607
3. it will be detect and normalized in other place, like:
https://github.com/apache/arrow/blob/main/cpp/src/parquet/column_reader.cc#L876
I'm not familiar with this when I previously working on this and I forgot
this for a long time. I may unify them these days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
