seddonm1 commented on a change in pull request #9509:
URL: https://github.com/apache/arrow/pull/9509#discussion_r577298569
##########
File path: rust/datafusion/src/physical_plan/functions.rs
##########
@@ -617,48 +670,137 @@ mod tests {
};
use arrow::{
array::{
- ArrayRef, FixedSizeListArray, Float64Array, Int32Array,
StringArray,
+ Array, ArrayRef, FixedSizeListArray, Float64Array, Int32Array,
StringArray,
UInt32Array, UInt64Array,
},
datatypes::Field,
record_batch::RecordBatch,
};
- fn generic_test_math(value: ScalarValue, expected: &str) -> Result<()> {
- // any type works here: we evaluate against a literal of `value`
- let schema = Schema::new(vec![Field::new("a", DataType::Int32,
false)]);
- let columns: Vec<ArrayRef> = vec![Arc::new(Int32Array::from(vec![1]))];
-
- let arg = lit(value);
-
- let expr = create_physical_expr(&BuiltinScalarFunction::Exp, &[arg],
&schema)?;
-
- // type is correct
- assert_eq!(expr.data_type(&schema)?, DataType::Float64);
-
- // evaluate works
- let batch = RecordBatch::try_new(Arc::new(schema.clone()), columns)?;
- let result = expr.evaluate(&batch)?.into_array(batch.num_rows());
-
- // downcast works
- let result = result.as_any().downcast_ref::<Float64Array>().unwrap();
-
- // value is correct
- assert_eq!(result.value(0).to_string(), expected);
-
- Ok(())
+ /// $FUNC function to test
+ /// $ARGS arguments (vec) to pass to function
+ /// $EXPECTED a Result<Option<$EXPECTED_TYPE>> where Result allows testing
errors and Option allows testing Null
+ /// $EXPECTED_TYPE is the expected value type
+ /// $DATA_TYPE is the function to test result type
+ /// $ARRAY_TYPE is the column type after function applied
+ macro_rules! test_function {
+ ($FUNC:ident, $ARGS:expr, $EXPECTED:expr, $EXPECTED_TYPE:ty,
$DATA_TYPE: ident, $ARRAY_TYPE:ident) => {
+ println!("{:?}", BuiltinScalarFunction::$FUNC);
Review comment:
it is just there to help debugging but happy to remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
