jorgecarleitao edited a comment on pull request #9509: URL: https://github.com/apache/arrow/pull/9509#issuecomment-780701060
Thanks a lot, @seddonm1 . I went through this PR again and I pull the code locally to understand the reason for the macro. I now get it that it is not easy to write this. :) I PRed something to your branch with a suggestion to reduce the risk of using that function (which is unsafe due to the `typed`) on non-string arrays and make it just use generics, that imo are usually easier to read because the constraints are specific. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
