joroKr21 opened a new pull request, #10075:
URL: https://github.com/apache/arrow-datafusion/pull/10075
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Follup to #9436.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
We need to use the physical extension codec consistently, so that UDFs
embedded in more complex expressions can also be serialized and deserialized.
Most importantly in `parse_required_physical_expr` which calls recursively into
`parse_physical_expr` and should be providing the original codec.
## What changes are included in this PR?
Add a `PhysicalExtensionCodec` parameter to more of the deserialization
functions that were using a `DefaultPhysicalExtensionCodec` previously. I have
left the the signature of public functions unchanged but they should be changed
in the next major release (left a TODO comments):
* `parse_physical_window_expr`
* `parse_protobuf_hash_partitioning`
* `parse_protobuf_file_scan_config`
## Are these changes tested?
I extended the test in `roundtrip_physical_plan.rs` to use a more complex
expression.
## Are there any user-facing changes?
No, but left a TODO for future changes.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
