joroKr21 commented on code in PR #10075:
URL:
https://github.com/apache/arrow-datafusion/pull/10075#discussion_r1565374332
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -123,25 +125,39 @@ pub fn parse_physical_sort_exprs(
///
/// # Arguments
///
-/// * `proto` - Input proto with physical window exprression node.
+/// * `proto` - Input proto with physical window expression node.
/// * `name` - Name of the window expression.
-/// * `registry` - A registry knows how to build logical expressions out of
user-defined function' names
+/// * `registry` - A registry knows how to build logical expressions out of
user-defined function names
/// * `input_schema` - The Arrow schema for the input, used for determining
expression data types
/// when performing type coercion.
pub fn parse_physical_window_expr(
proto: &protobuf::PhysicalWindowExprNode,
registry: &dyn FunctionRegistry,
input_schema: &Schema,
) -> Result<Arc<dyn WindowExpr>> {
- let codec = DefaultPhysicalExtensionCodec {};
+ parse_physical_window_expr_ext(
+ proto,
+ registry,
+ input_schema,
+ &DefaultPhysicalExtensionCodec {},
+ )
+}
+
+// TODO: Make this the public function on next major release.
Review Comment:
I added the breaking changes here in
[1f0040c](https://github.com/apache/arrow-datafusion/pull/10075/commits/1f0040c5d205f6e0cf56aa20cd61f3713b37f4d4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
