viirya commented on code in PR #10077:
URL:
https://github.com/apache/arrow-datafusion/pull/10077#discussion_r1564854439
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -435,15 +437,15 @@ fn coerced_from<'a>(
// Note that not all rules in `comparison_coercion` can be reused here.
// For example, all numeric types can be coerced into Utf8 for
comparison,
// but not for function arguments.
- _ => comparison_binary_numeric_coercion(type_into, type_from).and_then(
- |coerced_type| {
+ _ => comparison_binary_numeric_coercion(type_into, type_from)
+ .or_else(|| dictionary_coercion(type_into, type_from, true))
Review Comment:
Hmm, not sure I understand the comment. What you mean "check inner data type
with `coerced_from`"?
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -435,15 +437,15 @@ fn coerced_from<'a>(
// Note that not all rules in `comparison_coercion` can be reused here.
// For example, all numeric types can be coerced into Utf8 for
comparison,
// but not for function arguments.
- _ => comparison_binary_numeric_coercion(type_into, type_from).and_then(
- |coerced_type| {
+ _ => comparison_binary_numeric_coercion(type_into, type_from)
+ .or_else(|| dictionary_coercion(type_into, type_from, true))
Review Comment:
Hmm, not sure I understand the comment too. What you mean "check inner data
type with `coerced_from`"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
