viirya commented on code in PR #10077:
URL:
https://github.com/apache/arrow-datafusion/pull/10077#discussion_r1565122093
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -314,8 +314,13 @@ fn coerced_from<'a>(
// match Dictionary first
match (type_into, type_from) {
// coerced dictionary first
- (cur_type, Dictionary(_, value_type)) | (Dictionary(_, value_type),
cur_type)
- if coerced_from(cur_type, value_type).is_some() =>
Review Comment:
When coercing into dictionary type, the `type_into` and `type_from`
parameters are in incorrect order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
