adamreeve commented on code in PR #41226:
URL: https://github.com/apache/arrow/pull/41226#discussion_r1566514091
##########
csharp/test/Apache.Arrow.Tests/ArrowArrayConcatenatorTests.cs:
##########
@@ -604,10 +598,11 @@ public void Visit(UnionType type)
for (int j = 0; j < dataList.Count; j++)
{
- byte index = (byte)Math.Max(j % 3, 1);
+ byte index = (byte)Math.Min(j % 3, 1);
Review Comment:
I'm pretty sure this was the intended behaviour, otherwise the `index == 0`
branch below is never used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
