CurtHagenlocher commented on code in PR #41226:
URL: https://github.com/apache/arrow/pull/41226#discussion_r1566607918
##########
csharp/test/Apache.Arrow.Tests/ArrowArrayConcatenatorTests.cs:
##########
@@ -604,10 +598,11 @@ public void Visit(UnionType type)
for (int j = 0; j < dataList.Count; j++)
{
- byte index = (byte)Math.Max(j % 3, 1);
+ byte index = (byte)Math.Min(j % 3, 1);
Review Comment:
With the original code, the indexes would be 1, 1, 2, 1, 1, 2, etc.. With
this change, the indexes would be 0, 1, 1, 0, 1, 1, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
