andygrove commented on code in PR #10092:
URL:
https://github.com/apache/arrow-datafusion/pull/10092#discussion_r1566616203
##########
benchmarks/bench.sh:
##########
@@ -320,6 +326,21 @@ run_tpch() {
$CARGO_COMMAND --bin tpch -- benchmark datafusion --iterations 5 --path
"${TPCH_DIR}" --format parquet -o ${RESULTS_FILE}
}
+# Runs the tpch benchmark with sort merge join
+run_tpch_smj() {
+ SCALE_FACTOR=$1
+ if [ -z "$SCALE_FACTOR" ] ; then
+ echo "Internal error: Scale factor not specified"
+ exit 1
+ fi
+ TPCH_DIR="${DATA_DIR}/tpch_sf${SCALE_FACTOR}"
+
+ RESULTS_FILE="${RESULTS_DIR}/tpch_smj_sf${SCALE_FACTOR}.json"
+ echo "RESULTS_FILE: ${RESULTS_FILE}"
+ echo "Running tpch SMJ benchmark..."
+ $CARGO_COMMAND --bin tpch -- benchmark datafusion --iterations 5 --path
"${TPCH_DIR}" -j false --format parquet -o ${RESULTS_FILE}
Review Comment:
I think it would be clearer to use the full name of the new parameter here.
```suggestion
$CARGO_COMMAND --bin tpch -- benchmark datafusion --iterations 5 --path
"${TPCH_DIR}" --prefer_hash_join false --format parquet -o ${RESULTS_FILE}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
