alamb commented on code in PR #10092:
URL:
https://github.com/apache/arrow-datafusion/pull/10092#discussion_r1567617174
##########
benchmarks/src/tpch/run.rs:
##########
@@ -81,6 +84,10 @@ pub struct RunOpt {
/// Whether to disable collection of statistics (and cost based
optimizations) or not.
#[structopt(short = "S", long = "disable-statistics")]
disable_statistics: bool,
+
+ /// Whether to disable collection of statistics (and cost based
optimizations) or not.
+ #[structopt(short = "j", long = "hash-join", default_value = "true")]
+ prefer_hash_join: BoolDefaultTrue,
Review Comment:
I am worried that this might switch the `tpch` runs to using SMJ by accident
(given your comment above). I started some benchmark runs to see if we can get
some data one way or the other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
