viirya commented on code in PR #271:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/271#discussion_r1566794078
##########
core/Cargo.toml:
##########
@@ -66,10 +66,10 @@ itertools = "0.11.0"
chrono = { version = "0.4", default-features = false, features = ["clock"] }
chrono-tz = { version = "0.8" }
paste = "1.0.14"
-datafusion-common = { git = "https://github.com/viirya/arrow-datafusion.git";,
rev = "111a940" }
-datafusion = { default-features = false, git =
"https://github.com/viirya/arrow-datafusion.git";, rev = "111a940", features =
["unicode_expressions"] }
-datafusion-functions = { git =
"https://github.com/viirya/arrow-datafusion.git";, rev = "111a940" }
-datafusion-physical-expr = { git =
"https://github.com/viirya/arrow-datafusion.git";, rev = "111a940",
default-features = false, features = ["unicode_expressions"] }
+datafusion-common = { git = "https://github.com/viirya/arrow-datafusion.git";,
rev = "57b3be4" }
Review Comment:
It is pointed to my fork of DataFusion not just for this. We uses the fork
of arrow-rs to use a workaround for the Java Arrow bug. So we must use the fork
too in our DataFusion crate, otherwise rust compiler will complain duplicated
structs etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
