viirya commented on code in PR #271:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/271#discussion_r1567709071
##########
core/src/execution/operators/copy.rs:
##########
@@ -149,7 +149,10 @@ impl CopyStream {
.iter()
.map(|v| copy_or_cast_array(v))
.collect::<Result<Vec<ArrayRef>, _>>()?;
- RecordBatch::try_new(self.schema.clone(), vectors).map_err(|e|
arrow_datafusion_err!(e))
+
+ let options =
RecordBatchOptions::new().with_row_count(Some(batch.num_rows()));
+ RecordBatch::try_new_with_options(self.schema.clone(), vectors,
&options)
Review Comment:
Good catch. Although I'm not sure if it is possible to have `Expand` with
empty projections, it is good to have it here too. I will add it in this PR as
it is a simple change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
