alamb commented on code in PR #10089:
URL:
https://github.com/apache/arrow-datafusion/pull/10089#discussion_r1567400089
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -843,18 +802,9 @@ impl WindowUDFImpl for SimpleWindowUDF {
}
}
-/// Calls a named built in function
-pub fn call_fn(name: impl AsRef<str>, args: Vec<Expr>) -> Result<Expr> {
Review Comment:
This is an interesting API change -- I wonder if this API is used to call
functions by name in the expr API 🤔
However, it is currently going to be missing all the built in functions now
that we port them to UDFs so a compiler error is probably better than a runtime
error,
Maybe we can add such a function back eventually (using the API @jayzhan211
and @viirya were talking about in
https://github.com/apache/arrow-datafusion/issues/9892 🤔 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
