alamb commented on code in PR #10089:
URL:
https://github.com/apache/arrow-datafusion/pull/10089#discussion_r1567598780
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -843,18 +802,9 @@ impl WindowUDFImpl for SimpleWindowUDF {
}
}
-/// Calls a named built in function
-pub fn call_fn(name: impl AsRef<str>, args: Vec<Expr>) -> Result<Expr> {
Review Comment:
> it may have to live somewhere else unless a session context or something
similar is passed in though
Yes I agree with this. Now that there is no static global list of functions
some sort of state needs to get passed in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
