CurtHagenlocher commented on code in PR #1730:
URL: https://github.com/apache/arrow-adbc/pull/1730#discussion_r1571256402
##########
csharp/src/Drivers/Interop/Snowflake/Apache.Arrow.Adbc.Drivers.Interop.Snowflake.csproj:
##########
@@ -26,13 +36,67 @@
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
</ItemGroup>
- <ItemGroup>
+
+ <!-- What runs in the pipeline. Assumes the Go builds have happened. -->
+ <ItemGroup Condition="$([MSBuild]::IsOSPlatform('Linux'))">
<Content Include="readme.md">
<Pack>true</Pack>
<PackagePath>\</PackagePath>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
- </ItemGroup>
+
+ <!-- Windows/DLLs -->
+ <Content Include="libadbc_driver_snowflake.dll">
+ <Pack>true</Pack>
+ <PackagePath>lib\netstandard2.0</PackagePath>
Review Comment:
Isn't the convention here to put the platform-specific files into e.g.
runtimes/win-x64/native, runtimes/mac-arm64/native, etc? This would also avoid
needing multiple copies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
