zeroshade commented on code in PR #1730:
URL: https://github.com/apache/arrow-adbc/pull/1730#discussion_r1571340360
##########
csharp/src/Drivers/Interop/Snowflake/Apache.Arrow.Adbc.Drivers.Interop.Snowflake.csproj:
##########
@@ -26,13 +36,67 @@
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
</ItemGroup>
- <ItemGroup>
+
+ <!-- What runs in the pipeline. Assumes the Go builds have happened. -->
+ <ItemGroup Condition="$([MSBuild]::IsOSPlatform('Linux'))">
<Content Include="readme.md">
<Pack>true</Pack>
<PackagePath>\</PackagePath>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
- </ItemGroup>
+
+ <!-- Windows/DLLs -->
+ <Content Include="libadbc_driver_snowflake.dll">
+ <Pack>true</Pack>
+ <PackagePath>lib\netstandard2.0</PackagePath>
+ <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+ </Content>
+ <Content Include="libadbc_driver_snowflake.dll">
+ <Pack>true</Pack>
+ <PackagePath>lib\net472</PackagePath>
+ <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+ </Content>
+ <Content Include="libadbc_driver_snowflake.dll">
+ <Pack>true</Pack>
+ <PackagePath>lib\net6.0</PackagePath>
+ <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+ </Content>
+
+ <!-- Linux/so -->
+ <Content Include="libadbc_driver_snowflake.so">
+ <Pack>true</Pack>
+ <PackagePath>lib\netstandard2.0</PackagePath>
+ <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+ </Content>
+ <Content Include="libadbc_driver_snowflake.so">
+ <Pack>true</Pack>
+ <PackagePath>lib\net472</PackagePath>
+ <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+ </Content>
+ <Content Include="libadbc_driver_snowflake.so">
+ <Pack>true</Pack>
+ <PackagePath>lib\net6.0</PackagePath>
+ <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+ </Content>
+
+ <!-- Mac/dylib -->
+ <Content Include="libadbc_driver_snowflake.dylib">
Review Comment:
You would need separate binaries for x64 and arm64. You can control the
build by using `GOARCH=arm64` or `GOARCH=amd64` if you want to cross compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
