ZhangHuiGui commented on code in PR #41295:
URL: https://github.com/apache/arrow/pull/41295#discussion_r1572073267
##########
cpp/src/arrow/compute/kernels/codegen_internal.cc:
##########
@@ -57,8 +57,14 @@ Result<TypeHolder> LastType(KernelContext*, const
std::vector<TypeHolder>& types
}
Result<TypeHolder> ListValuesType(KernelContext*, const
std::vector<TypeHolder>& args) {
Review Comment:
The logic here seems correct for the `recursive = false` condition except
one more `value_kind` check on `is_list(value_kind) ||
is_list_view(value_kind)`.
And it's the output resolver(a callback to identify the kernel functions's
output type) which called only once in expression bind or CallFunction's, and
have little impact on kernel path. So maybe the logic here could be retained?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
