ZhangHuiGui commented on code in PR #41295:
URL: https://github.com/apache/arrow/pull/41295#discussion_r1583640463
##########
cpp/src/arrow/compute/kernels/vector_nested_test.cc:
##########
@@ -29,41 +30,114 @@ namespace compute {
using arrow::internal::checked_cast;
-TEST(TestVectorNested, ListFlatten) {
- for (auto ty : {list(int16()), large_list(int16())}) {
- auto input = ArrayFromJSON(ty, "[[0, null, 1], null, [2, 3], []]");
- auto expected = ArrayFromJSON(int16(), "[0, null, 1, 2, 3]");
+using ListAndListViewTypes =
+ ::testing::Types<ListType, LargeListType, ListViewType, LargeListViewType>;
+
+// ----------------------------------------------------------------------
+// [Large]List and [Large]ListView tests
+template <typename T>
+class TestVectorLogicalList : public ::testing::Test {
Review Comment:
Thanks, agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
