peter-toth commented on PR #10126: URL: https://github.com/apache/arrow-datafusion/pull/10126#issuecomment-2066260765
> Thanks, @peter-toth—this really simplifies things. I'm wondering if there's an option to avoid changing the transform's `Fn` to `FnMut` (thus not requiring `&mut` for closures) by using the rewrite API for passes that need mutability inevitably. AFAIK rewrite can handle that for the `transform_up` and `transform_down` cases. My concern is that it would require to refactor all current `transform_down_mut()` and `transform_up_mut()` usecases to use the `rewrite()` API, which is a bigger change required from the API users than just change to `transform_down()` (or `transform_up()`) and `&` to `&mut`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
