alamb commented on code in PR #10126:
URL:
https://github.com/apache/arrow-datafusion/pull/10126#discussion_r1572283379
##########
datafusion-examples/examples/function_factory.rs:
##########
@@ -164,7 +164,7 @@ impl ScalarUDFImpl for ScalarFunctionWrapper {
impl ScalarFunctionWrapper {
// replaces placeholders such as $1 with actual arguments (args[0]
fn replacement(expr: &Expr, args: &[Expr]) -> Result<Expr> {
- let result = expr.clone().transform(&|e| {
+ let result = expr.clone().transform(|e| {
Review Comment:
I actually think this is a really nice improvement in usability -- to not
have to put a `&` in front of the closure is 💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
