bkietz commented on code in PR #404:
URL: https://github.com/apache/arrow-nanoarrow/pull/404#discussion_r1573056383
##########
src/nanoarrow/nanoarrow.hpp:
##########
@@ -548,6 +550,312 @@ class VectorArrayStream {
/// @}
+struct Nothing {};
Review Comment:
This doesn't seem to handle templates too well. I've added tests for
RandomAccessRange and InputRange as well. If we bring in ArrayFromJSON or
something, we could also have meaningful tests for View*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
