paleolimbot commented on code in PR #404:
URL: https://github.com/apache/arrow-nanoarrow/pull/404#discussion_r1574933882
##########
src/nanoarrow/nanoarrow.hpp:
##########
@@ -548,6 +550,312 @@ class VectorArrayStream {
/// @}
+struct Nothing {};
Review Comment:
I know it is a bit circular, but testing the "create by buffer, consume by
View" direction for at least one instantation of each template in the
user-facing header is what I had in mind. Creating by buffer is not too bad in
C++ using the pattern from the benchmarks:
https://github.com/apache/arrow-nanoarrow/blob/db6630b7770d33edc5227f60929a269a4aff8a04/dev/benchmarks/c/array_benchmark.cc#L36-L43
...plus the newly added helpers to create buffers from C++ sequences (which
we can't use in the bechmarks or they won't build against the previous version):
https://github.com/apache/arrow-nanoarrow/blob/db6630b7770d33edc5227f60929a269a4aff8a04/src/nanoarrow/nanoarrow_hpp_test.cc#L206-L234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
