lidavidm commented on code in PR #1749:
URL: https://github.com/apache/arrow-adbc/pull/1749#discussion_r1576103518
##########
.github/workflows/rust.yml:
##########
@@ -47,22 +48,38 @@ jobs:
os: [windows-latest, macos-latest, ubuntu-latest]
name: "Rust ${{ matrix.os }}"
runs-on: ${{ matrix.os }}
+ env:
+ CARGO_INCREMENTAL: 0
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false
- - name: Install stable toolchain
- uses: dtolnay/rust-toolchain@stable
+ - name: Use stable Rust
+ id: rust
+ run: |
+ rustup update stable
+ rustup default stable
+ VERSION=$(rustup show active-toolchain -v | tail -1 | tr -d
"[:space:]")
+ echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+ - uses: actions/cache@v4
with:
- components: clippy, rustfmt
- - uses: Swatinem/rust-cache@v2
- - name: Check format
- run: cargo fmt -- --check
+ path: |
+ ~/.cargo/bin/
+ ~/.cargo/registry/index/
+ ~/.cargo/registry/cache/
+ ~/.cargo/git/db/
+ rust/target/
+ key: ${{ runner.os }}-cargo-${{ steps.rust.outputs.version }}-${{
hashFiles('**/Cargo.lock') }}
+ restore-keys: |
+ ${{ runner.os }}-cargo-${{ steps.rust.outputs.version }}-
+ - name: Rustfmt
+ run: cargo fmt --all -- --check
Review Comment:
Ideally this would be in pre-commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
