alexandreyc commented on code in PR #1749: URL: https://github.com/apache/arrow-adbc/pull/1749#discussion_r1576129805
########## rust/Cargo.lock: ########## @@ -0,0 +1,799 @@ +# This file is automatically @generated by Cargo. Review Comment: I'm not totally convinced that `Cargo.lock` must be checked-in for libraries. After checking some of the most popular crates, almost none of them have it (arrow-rs neither). On the contrary, I can't find any good reason to not have it 😃 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
