davidhcoe commented on code in PR #1752:
URL: https://github.com/apache/arrow-adbc/pull/1752#discussion_r1577215151
##########
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverExporter.cs:
##########
@@ -708,13 +754,8 @@ public void Dispose()
connection = null;
}
- public unsafe AdbcStatusCode GetObjects(ref CAdbcConnection
nativeConnection, int depth, byte* catalog, byte* db_schema, byte* table_name,
byte** table_type, byte* column_name, CArrowArrayStream* cstream, ref
CAdbcError error)
+ public unsafe void GetObjects(ref CAdbcConnection
nativeConnection, int depth, byte* catalog, byte* db_schema, byte* table_name,
byte** table_type, byte* column_name, CArrowArrayStream* cstream)
Review Comment:
why the switch to void? I believe this has to return the AdbcStatusCode per
https://github.com/apache/arrow-adbc/blob/3f80831d12b6e5a78a4321f67e28d652951241cf/adbc.h#L1609.
##########
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverExporter.cs:
##########
@@ -685,7 +733,7 @@ public ConnectionStub(AdbcDriver driver)
options = new Dictionary<string, string>();
}
- public unsafe AdbcStatusCode SetOption(byte* name, byte* value,
ref CAdbcError error)
+ public unsafe void SetOption(byte* name, byte* value)
Review Comment:
same as GetObjects - why the switch to void?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
