CurtHagenlocher commented on code in PR #1752:
URL: https://github.com/apache/arrow-adbc/pull/1752#discussion_r1577776163
##########
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverExporter.cs:
##########
@@ -708,13 +754,8 @@ public void Dispose()
connection = null;
}
- public unsafe AdbcStatusCode GetObjects(ref CAdbcConnection
nativeConnection, int depth, byte* catalog, byte* db_schema, byte* table_name,
byte** table_type, byte* column_name, CArrowArrayStream* cstream, ref
CAdbcError error)
+ public unsafe void GetObjects(ref CAdbcConnection
nativeConnection, int depth, byte* catalog, byte* db_schema, byte* table_name,
byte** table_type, byte* column_name, CArrowArrayStream* cstream)
Review Comment:
This is an inner layer of the API, not the outermost one. As I needed to
catch all exceptions on the outermost layer anyway, I decided to unify on
exceptions for error handling on other layers. Any function pointer exposed
directly via the C API will be marked as [UnmanagedCallersOnly] and these
should now all have a catch block which converts exceptions into AdbcErrors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
