xxchan commented on issue #5368: URL: https://github.com/apache/arrow-rs/issues/5368#issuecomment-2074450479
reply https://github.com/apache/arrow-rs/pull/5566#issuecomment-2058726712 here > I think it may be classified as a breaking change in that it'll require consumers to upgrade their pyo3 version This sounds like bumping MSRV. Consumers are required to bump their Rust version, but there are strong arguments that this should not be a semver breaking change. https://github.com/rust-lang/api-guidelines/discussions/231#discussioncomment-3746774 I’m not familiar with pyo3, and not sure whether the analogy is precise though. From a more practical point of view, I think it depends on whether bumping major version brings benefits to users. For users don’t use pyo3, it’s definitely brings disadvantages. For users using pyo3, the workload seems to be the same. They can just pin to older arrow version if they don’t want to upgrade pyo3 for a while. (Similar to the solution for MSRV) There seems to be no large difference whether they pin to an older major or minor arrow version. I now roughly feel that bumping major version unnecessarily might bring more harm (in productivity) in the ecosystem than including some “little” breaking changes in minor versions (like tokio unstable). Although the latter might be more “correct”. Just random personal feeling, correct me if I’m wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
