kou commented on code in PR #41359:
URL: https://github.com/apache/arrow/pull/41359#discussion_r1578524391
##########
cpp/src/arrow/device.h:
##########
@@ -150,9 +150,10 @@ class ARROW_EXPORT Device : public
std::enable_shared_from_this<Device>,
/// @param release_fn a function to call during destruction, `nullptr` or
/// a no-op function can be passed to indicate ownership is maintained
/// externally
- virtual Result<std::shared_ptr<Stream>> WrapStream(
- [[maybe_unused]] void* device_stream,
- [[maybe_unused]] Stream::release_fn_t release_fn) {
+ virtual Result<std::shared_ptr<Stream>> WrapStream(void* device_stream,
+ Stream::release_fn_t
release_fn) {
+ ARROW_UNUSED(device_stream);
+ ARROW_UNUSED(release_fn);
Review Comment:
Can we use `ARROW_ARG_UNUSED()` by adding `ARROW_ARG_UNUSED(x)=x` to
Doxygen's `PREDEFINED`?
(`ARROW_ARG_UNUSED(x)=x` is added and the list is sorted.)
```diff
diff --git a/cpp/apidoc/Doxyfile b/cpp/apidoc/Doxyfile
index e19c933cd4..5be93032c0 100644
--- a/cpp/apidoc/Doxyfile
+++ b/cpp/apidoc/Doxyfile
@@ -2168,16 +2168,17 @@ INCLUDE_FILE_PATTERNS =
PREDEFINED = __attribute__(x)= \
__declspec(x)= \
- PARQUET_EXPORT= \
- GANDIVA_EXPORT= \
- ARROW_EXPORT= \
ARROW_ACERO_EXPORT= \
+ ARROW_ARG_UNUSED(x)=x \
+ ARROW_DEPRECATED(x)= \
ARROW_DS_EXPORT= \
ARROW_ENGINE_EXPORT= \
+ ARROW_EXPORT= \
+ ARROW_EXTERN_TEMPLATE= \
ARROW_FLIGHT_EXPORT= \
ARROW_FLIGHT_SQL_EXPORT= \
- ARROW_EXTERN_TEMPLATE= \
- ARROW_DEPRECATED(x)=
+ GANDIVA_EXPORT= \
+ PARQUET_EXPORT=
# If the MACRO_EXPANSION and EXPAND_ONLY_PREDEF tags are set to YES then
this
# tag can be used to specify a list of macro names that should be expanded.
The
```
See also: https://www.doxygen.nl/manual/preprocessing.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
