WillAyd commented on code in PR #41359:
URL: https://github.com/apache/arrow/pull/41359#discussion_r1580213043
##########
cpp/src/arrow/device.h:
##########
@@ -150,9 +150,10 @@ class ARROW_EXPORT Device : public
std::enable_shared_from_this<Device>,
/// @param release_fn a function to call during destruction, `nullptr` or
/// a no-op function can be passed to indicate ownership is maintained
/// externally
- virtual Result<std::shared_ptr<Stream>> WrapStream(
- [[maybe_unused]] void* device_stream,
- [[maybe_unused]] Stream::release_fn_t release_fn) {
+ virtual Result<std::shared_ptr<Stream>> WrapStream(void* device_stream,
+ Stream::release_fn_t
release_fn) {
+ ARROW_UNUSED(device_stream);
+ ARROW_UNUSED(release_fn);
Review Comment:
After some more digging it seems like what you suggested works for Doxygen
to generate the appropriate output, but that seems to have no bearing on clang.
I think this issue upstream is related
https://github.com/llvm/llvm-project/issues/77489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
