alexandreyc commented on code in PR #1756: URL: https://github.com/apache/arrow-adbc/pull/1756#discussion_r1579295405
########## rust/core/src/lib.rs: ########## @@ -49,12 +48,18 @@ //! The [driver_manager] module allows loading drivers exposing the C API, //! either from an initialization function (link-time, either static or dynamic) //! or by dynamically finding such a function in a dynamic library (run-time). +//! # Driver Exporter +//! +//! The driver exporter allows exposing native Rust drivers as C drivers to be +//! used by other langages via their own driver manager. Once you have an +//! implementation of [Driver], provided that it also implements [Default], you +//! can build it as an object file implementing the C API with the +//! [export_driver] macro. // TODO(alexandreyc): uncomment these lines during follow-up PRs -// pub mod driver_exporter; // pub mod driver_manager; -// pub use ffi::FFI_AdbcDriverInitFunc as AdbcDriverInitFunc; - +#[doc(hidden)] +pub mod driver_exporter; Review Comment: Done. I still had to make `FFIDriver` (or `make_ffi_driver`) public (but doc hidden) because it's used in the `export_driver` macro which is public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
