raulcd commented on code in PR #37298:
URL: https://github.com/apache/arrow/pull/37298#discussion_r1580820063
##########
cpp/src/arrow/extension/CMakeLists.txt:
##########
@@ -15,10 +15,16 @@
# specific language governing permissions and limitations
# under the License.
+set(CANONICAL_EXTENSION_TESTS uuid_test.cc)
+
+if(ARROW_JSON)
Review Comment:
this shouldn't be required now that you are building extensions even without
`ARROW_JSON`, right?
##########
cpp/src/arrow/extension_type.cc:
##########
@@ -145,12 +146,17 @@ static void CreateGlobalRegistry() {
g_registry = std::make_shared<ExtensionTypeRegistryImpl>();
#ifdef ARROW_JSON
Review Comment:
I think the `ARROW_JSON` was only required because we were having a bug on
CMake that you are fixing right now. Why should `fixed_shape_tensor` has
nothing to do with JSON?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
