rok commented on code in PR #37298:
URL: https://github.com/apache/arrow/pull/37298#discussion_r1581445564


##########
cpp/src/arrow/extension_type.cc:
##########
@@ -145,12 +146,17 @@ static void CreateGlobalRegistry() {
   g_registry = std::make_shared<ExtensionTypeRegistryImpl>();
 
 #ifdef ARROW_JSON

Review Comment:
   `fixed_shape_tensor` uses rapidjson to serialize and deserialize metadata 
(see `FixedShapeTensorType::Serialize` and `FixedShapeTensorType::Deserialize`) 
of the type so we need `ARROW_JSON` to build it. UUID has no metadata to 
serialize so we don't require JSON. It's annoying that for some builds we get 
all extensions and for some only a subset, but I don't have a better idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to