zeroshade commented on code in PR #40807:
URL: https://github.com/apache/arrow/pull/40807#discussion_r1581172015
##########
cpp/src/arrow/array/data.cc:
##########
@@ -224,6 +224,36 @@ int64_t ArrayData::ComputeLogicalNullCount() const {
return ArraySpan(*this).ComputeLogicalNullCount();
}
+DeviceAllocationType ArrayData::device_type() const {
+ int type = 0;
Review Comment:
For the `type == 0`, we explicitly don't have an "UNASSIGNED" value in the
enum or the macros because we don't want that to be used or seen as a
potentially valid value for the C struct or the enum. Notice that there's no
situation in which we actually return the 0 here.
I'd be fine with defining it *internally* to the library as a sentinel
constant, but I don't want it to ever end up externally viewable and was trying
to keep it that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
