zeroshade commented on PR #40807: URL: https://github.com/apache/arrow/pull/40807#issuecomment-2079607152
> Just to check my understanding of this change: sync events are now propagated from device arrays to record batches (in addition to all the buffers in all the arrays in the record batch); however, one would have to specifically specify a sync event explicitly if constructing a record batch from (say) some arrays (or else it will return nullptr, meaning "the batch is synchronized" or "I'm handling synchronization myself"). Yep. That's the current situational understanding. > It seems as though you are punting on sync events for the Array for now...is walking all the buffers and checking for the same underlying non-null sync event pointer prohibitively expensive? I didn't want to require the same underlying non-null sync event pointer in all children as that would make it difficult to manipulate / update / construct record batches from arrays gathered from multiple places. But we don't currently have any sort of API for defining how to merge / join events into a single event and I didn't want to try to tackle that in this PR. essentially, it's not prohibitively expensive, we just don't want that to be a requirement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
