jorisvandenbossche commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1586242110
##########
python/setup.py:
##########
@@ -133,8 +143,68 @@ def run(self):
'bundle the Arrow C++ headers')] +
_build_ext.user_options)
+ def get_arrow_build_options(self):
Review Comment:
> You can use https://github.com/apache/arrow/pull/37822/files#r1344887227
for this approach.
As @joemarshall mentioned, right now that is not directly possible because
we also use those variables from within `setup.py` for other reasons.
However, I have been looking a bit into that, and to me it seems this is
only used for the "failure_permitted" logic, which I am not sure if that is
something we necessarily need to keep.
So if we remove that logic, then we can indeed move the environment variable
handling fully to the CMakeLists file, making this a lot simpler. Given this is
already a big PR, I think this is something we can discuss and review
separately, so I opened https://github.com/apache/arrow/issues/41480 for this.
(@joemarshall I am also happy to take this on if you want, and ensure to
move that forward so this doesn't need to block this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
