zanmato1984 commented on PR #41335: URL: https://github.com/apache/arrow/pull/41335#issuecomment-2090999864
> I agree that per-node stacks are a reasonable solution. I think Antoine's solution is also a reasonable solution. > > I'd be happy with either approach. I'm in favor of the per-node stack approach as the presumption about the overflow-ness of shared stack doesn't stand no more. Plus the following additional reasons: 1) it doesn't introduce more performance penalty than shared stack; 2) it can mitigate the overflow in a natural way, i.e., expanding the stack size linear to the number of nodes; 3) it requires no more complexity to the existing stack implementation. And my apology to @felipecrv . As the full story has been gradually pieced together in the subsequent discussions in this PR, though I hate to say this, the original intention of this PR is not necessary any more. I appreciate your kind and insightful review, and sorry for your trouble :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
