felipecrv commented on code in PR #41373:
URL: https://github.com/apache/arrow/pull/41373#discussion_r1588599102
##########
cpp/src/arrow/compute/kernels/vector_selection_take_internal.cc:
##########
@@ -884,13 +756,11 @@ void
PopulateTakeKernels(std::vector<SelectionKernelData>* out) {
auto take_indices = match::Integer();
*out = {
- {InputType(match::Primitive()), take_indices, PrimitiveTakeExec},
+ {InputType(match::Primitive()), take_indices, FixedWidthTakeExec},
{InputType(match::BinaryLike()), take_indices, VarBinaryTakeExec},
{InputType(match::LargeBinaryLike()), take_indices,
LargeVarBinaryTakeExec},
- {InputType(Type::FIXED_SIZE_BINARY), take_indices, FSBTakeExec},
+ {InputType(match::FixedSizeBinaryLike()), take_indices,
FixedWidthTakeExec},
{InputType(null()), take_indices, NullTakeExec},
- {InputType(Type::DECIMAL128), take_indices, PrimitiveTakeExec},
- {InputType(Type::DECIMAL256), take_indices, PrimitiveTakeExec},
Review Comment:
"FixedSizeBinaryLike" includes FSB and the Decimal types. Not to be confused
with "fixed-WIDTH like" which includes special fixed-size lists (see
`util/fixed_width_internal.h`). I wanted to name the latter "fixed-width modulo
nesting" to be more upfront about the nesting aspect, but that turned out too
obtuse and verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
