felipecrv commented on code in PR #41373: URL: https://github.com/apache/arrow/pull/41373#discussion_r1591364990
########## cpp/src/arrow/util/macros.h: ########## @@ -102,7 +102,7 @@ #elif defined(_MSC_VER) // MSVC #define ARROW_NORETURN __declspec(noreturn) #define ARROW_NOINLINE __declspec(noinline) -#define ARROW_FORCE_INLINE __declspec(forceinline) +#define ARROW_FORCE_INLINE __forceinline Review Comment: I messed this up in a previous PR. `__declspec(forceinline)` is not really a thing in MSVC. I mistakenly changed this from `__forceinline` to `__declspec(forceinline)`. Now that there is a use, it failed the MSVC builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
