HadrienG2 opened a new pull request, #5721:
URL: https://github.com/apache/arrow-rs/pull/5721
# Which issue does this PR close?
Closes #5711.
# Rationale for this change
It seems everyone at #5711 has so far agreed that having
`NullBuilder::with_capacity()` set the builder **length** is surprising, and
that the notion of capacity makes no sense for this builder in general.
Therefore, this PR is deprecating the notion of `NullBuilder` capacity where
possible, and ignoring capacity in the edge case of `NullArray::builder()`
where the function paramater cannot really be _deprecated_.
# What changes are included in this PR?
- `NullBuilder::with_capacity()` and `NullBuilder::capacity()` are deprecated
- `NullBuilder::with_capacity()` and `NullArray::builder()` are switched to
the more sensible behavior of ignoring input capacity instead of setting a
nonzero initial builder length.
# Are there any user-facing changes?
Both changes listed above are technically user-facing.
Although it does affect API semantics, I don't think making
`NullBuilder::with_capacity()` and `NullArray::builder()` ignore their argument
should be considered a breaking change, beacause the current behavior of
setting the length was considered to be a bug in #5711 discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
