jorisvandenbossche commented on code in PR #41538:
URL: https://github.com/apache/arrow/pull/41538#discussion_r1592179492
##########
python/pyarrow/tests/test_types.py:
##########
@@ -1331,7 +1331,7 @@ def __init__(self, schema):
def __arrow_c_schema__(self):
return self.schema.__arrow_c_schema__()
- schema = pa.schema([pa.field("field_name", pa.int32())])
+ schema = pa.schema([pa.field("field_name", pa.int32())], metadata={"a",
"b"})
wrapped_schema = Wrapper(schema)
assert pa.schema(wrapped_schema) == schema
Review Comment:
What you additionally need to test is `pa.schema(wrapped_schema,
metadata=..)`, i.e. passing metadata to the `pa.schema(..)` constructor
function when passing a schema object to it (the test as you edited it now will
already pass, I think, and so not cover the regression)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
