jorisvandenbossche commented on code in PR #41538:
URL: https://github.com/apache/arrow/pull/41538#discussion_r1603624794
##########
python/pyarrow/tests/test_types.py:
##########
@@ -1331,10 +1331,13 @@ def __init__(self, schema):
def __arrow_c_schema__(self):
return self.schema.__arrow_c_schema__()
- schema = pa.schema([pa.field("field_name", pa.int32())])
+ schema = pa.schema([pa.field("field_name", pa.int32())], metadata={"a":
"b"})
+ assert schema.metadata == {b"a": b"b"}
wrapped_schema = Wrapper(schema)
assert pa.schema(wrapped_schema) == schema
+ assert pa.schema(wrapped_schema).metadata == {b"a": b"b"}
Review Comment:
Added this additional line, because `assert pa.schema(wrapped_schema) ==
schema` (the line above) in itself does not check the metadata (that gets
ignored in basic equality testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
