paleolimbot commented on code in PR #456:
URL: https://github.com/apache/arrow-nanoarrow/pull/456#discussion_r1594196747
##########
python/tests/test_c_array_stream.py:
##########
@@ -144,12 +143,12 @@ def test_array_stream_from_arrays_validate():
array_in = na.c_array([1, 2, 3], na.int32())
# Check that we can skip validation and proceed without error
- stream = CArrayStream.from_array_list([array_in], schema_in,
validate=False)
+ stream = CArrayStream.from_c_arrays([array_in], schema_in, validate=False)
arrays = list(stream)
assert len(arrays) == 1
assert arrays[0].n_buffers == 2
# ...but that validation does happen by default
- msg = "Expected array with 0 buffer"
- with pytest.raises(NanoarrowException, match=msg):
- CArrayStream.from_array_list([array_in], schema_in)
+ msg = "Expected schema na but got int32"
Review Comment:
'na' comes from deep in the C library (the definitely suboptimal
representation of the 'null' type as a string). I did make the message better
though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
