paleolimbot commented on code in PR #456:
URL: https://github.com/apache/arrow-nanoarrow/pull/456#discussion_r1594266682
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -769,6 +769,35 @@ cdef class CSchema:
def __repr__(self):
return _repr_utils.schema_repr(self)
+ def type_equals(self, CSchema other):
+ self._assert_valid()
+
+ if self._ptr == other._ptr:
+ return True
+
+ if self.format != other.format:
+ return False
+
+ if self.flags != other.flags:
+ return False
+
Review Comment:
It's the appropriate check for the purposes of ensuring an iterable of
arrays can be safely interpreted according to a given schema but it's a good
point that nullability is not strictly part of the "type". I'll make that part
optional (although this is internal for now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
