birschick-bq commented on code in PR #1830:
URL: https://github.com/apache/arrow-adbc/pull/1830#discussion_r1594832633
##########
csharp/src/Drivers/Apache/Spark/SparkConnection.cs:
##########
@@ -134,23 +134,6 @@ public override AdbcStatement CreateStatement()
return new SparkStatement(this);
}
- public override void Dispose()
- {
- /*
- if (this.client != null)
- {
- TCloseSessionReq r6 = new TCloseSessionReq(this.sessionHandle);
- this.client.CloseSession(r6).Wait();
-
- this.transport.Close();
- this.client.Dispose();
-
- this.transport = null;
- this.client = null;
- }
- */
- }
-
public override IArrowArrayStream GetInfo(IReadOnlyList<AdbcInfoCode>
codes)
Review Comment:
Just to be clear, if you're referring to the removed `Dispose`, there is a
correct implementation of the `Dispose` in the base class
`HiveServer2Statement`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
