birschick-bq commented on code in PR #1830:
URL: https://github.com/apache/arrow-adbc/pull/1830#discussion_r1594833194
##########
csharp/src/Drivers/Apache/Spark/SparkStatement.cs:
##########
@@ -102,6 +102,10 @@ public override UpdateResult ExecuteUpdate()
return new UpdateResult(affectedRows ?? -1);
}
+ public override QueryResult ExecuteQuery() =>
ExecuteQueryAsync().AsTask().Result;
+
+ public override UpdateResult ExecuteUpdate() =>
ExecuteUpdateAsync().Result;
+
Review Comment:
Move the implementations of `ExecuteQuery`, `ExecuteUpdate`,
`ExecuteQueryAsync` and `ExecuteUpdateAsync` to the base class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
